Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

official sv06 configuration #1083

Merged
merged 13 commits into from
Aug 16, 2024
Merged

Conversation

mrpond
Copy link
Contributor

@mrpond mrpond commented Jul 15, 2024

Description

Configuration taken from Sovol3D's GitHub repository.
Disable #define SPEAKER relate to below issue.

  • untested, at the time of commit I'm still waiting for SV06 📦 to delivery.

Benefits

Added SV06 configuration

Related Issues

MarlinFirmware/Marlin#26982

@mrpond mrpond changed the title Port from official sv06 configuration official sv06 configuration Jul 15, 2024
@thinkyhead
Copy link
Member

Thanks for the contribution! Configurations need to be based on the current import-2.1.x development branch for acceptance. I went ahead and updated the configurations by hand. I might have missed something, so you should double check them and make sure they work properly with the bugfix-2.1.x branch, which will be the basis for the next release, 2.1.3. You might also want to enable and test some of the new features (like Input Shaping and provide default tuning values), which Sovol may not have tuned out of the box. Reviewers did note that other Sovol SV0x models had poor calibration out of the box, so we want to make sure we're doing a good job of fixing those up.

keep original sv06 as much as possible until I got my hand on sv06
@mrpond
Copy link
Contributor Author

mrpond commented Jul 22, 2024

Hi, I do use the config.ini to generate these.
sv06.zip

Compile successfully on Marlin bugfix-2.1.x
7f0d7e760b87bad296fee946b9afd2f6e3925f28

my platformio.ini
change config.ini into sv06.ini

[platformio]
src_dir      = Marlin
boards_dir   = buildroot/share/PlatformIO/boards
default_envs = GD32F103RET6_sovol_maple
include_dir  = Marlin
extra_configs =
    Marlin/sv06.ini

....


I do revert some of your change,
e.g. PID_PARAMS_PER_HOTEND is not enable, else condition apply

ADVANCE_K { 0.04 } -> 0.04 the sanity check error when add { }

PROBE_OFFSET_ZMIN/ ZMAX ifndef already -20 / 20

@thisiskeithb
Copy link
Member

You've changed a bunch of spacing and removed config defines in b8d2d2b that should remain.

@mrpond
Copy link
Contributor Author

mrpond commented Jul 22, 2024

You've changed a bunch of spacing and removed config defines in b8d2d2b that should remain.

Hi, I didn't do these by hand.
those are by marlin build script. check sv06.zip

some of define already done upstream, so I remove it

@thisiskeithb
Copy link
Member

Hi, I didn't do these by hand.
those are by marlin build script.

Even so, the changes need to be reverted, so please revert them and push an update.

@mrpond
Copy link
Contributor Author

mrpond commented Jul 22, 2024

Hi, I didn't do these by hand.
those are by marlin build script.

Even so, the changes need to be reverted, so please revert them and push an update.

done, I'm not sure if it correct. please check

@mrpond
Copy link
Contributor Author

mrpond commented Aug 10, 2024

@thinkyhead I got real hardware now, configuration working

photo_2024-08-10_21-25-05
photo_2024-08-10_21-25-06
photo_2024-08-10_21-25-09
photo_2024-08-10_21-25-07

Untitled.video.-.Made.with.Clipchamp.mp4

@thinkyhead thinkyhead merged commit b30aa49 into MarlinFirmware:import-2.1.x Aug 16, 2024
1 check passed
@thinkyhead
Copy link
Member

Thanks for all your work and testing! I reduced the motor current for homing by a small amount. It should not make a huge difference in homing behavior, but feel free to tune those currents a bit more and submit an update.

@mrpond
Copy link
Contributor Author

mrpond commented Aug 17, 2024

Thanks for all your work and testing! I reduced the motor current for homing by a small amount. It should not make a huge difference in homing behavior, but feel free to tune those currents a bit more and submit an update.

Tested, homing working fine.

rngkll pushed a commit to rngkll/Configurations that referenced this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants