Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🩹 Fix Formbot T-Rex 2+ X2 max position #1056

Conversation

thisiskeithb
Copy link
Member

@thisiskeithb thisiskeithb commented May 21, 2024

Description

While running the build_all_examples script, this config would not build:

In file included from Marlin/src/HAL/AVR/../../inc/MarlinConfigPre.h:56:0,
                 from Marlin/src/HAL/AVR/../../inc/MarlinConfig.h:28,
                 from Marlin/src/HAL/AVR/HAL.cpp:24:
Marlin/src/HAL/AVR/../../inc/../../Configuration_adv.h:823:24: error: floating constant in preprocessor expression
   #define X2_MAX_POS   434.6      // The max position of the X2 carriage, typically also the home position
                        ^

Rounding X2_MAX_POS down to 434 prevents the error and allows the config to build.

Benefits

Config now builds.

Related Issues

@thisiskeithb
Copy link
Member Author

Talking with @InsanityAutomation, he says that we need to allow floats in MIN/MAX positions for proper IDEX operation, so that will need to get fixed upstream.

@thisiskeithb thisiskeithb marked this pull request as draft May 21, 2024 21:43
@thisiskeithb thisiskeithb changed the title Fix Formbot T-Rex 2+ X2 max position 🩹 Fix Formbot T-Rex 2+ X2 max position May 29, 2024
Fix "floating constant in preprocessor expression" error.
@thisiskeithb
Copy link
Member Author

Apparently these TREX configs are very broken according to @InsanityAutomation, so I'll just close this for now as they won't work anyway.

@thisiskeithb thisiskeithb deleted the pr/fix_formbot_trex_2 branch June 24, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant