Skip to content

Commit

Permalink
Add missing parentheses in DTTSCand::isLL()
Browse files Browse the repository at this point in the history
Logical not is applied to int value, which is a clear mistake.
The patch applies logical not to the comparison.

    L1Trigger/DTTriggerServerPhi/interface/DTTSCand.h:119:77: warning:
    comparison of constant '8' with boolean expression is always false
    [-Wbool-compare]
    L1Trigger/DTTriggerServerPhi/interface/DTTSCand.h:120:77: warning:
    logical not is only applied to the left hand side of comparison
    [-Wlogical-not-parentheses]
    L1Trigger/DTTriggerServerPhi/interface/DTTSCand.h:120:77: warning:
    comparison of constant '80' with boolean expression is always false
    [-Wbool-compare]

Signed-off-by: David Abdurachmanov <[email protected]>
(cherry picked from commit 168db81)
  • Loading branch information
David Abdurachmanov authored and cmsbuild committed Jan 21, 2016
1 parent 18f5694 commit 137c224
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions L1Trigger/DTTriggerServerPhi/interface/DTTSCand.h
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,8 @@ class DTTSCand {
inline int isLH() const { return _tctrig->pvCorr() && _tctrig->pvCode()==8; }

/// Return if LL
inline int isLL() const { return _tctrig->pvCorr() && !_tctrig->pvCode()==8 &&
!_tctrig->pvCode()==80; }
inline int isLL() const { return _tctrig->pvCorr() && !(_tctrig->pvCode()==8) &&
!(_tctrig->pvCode()==80); }
/// Return if H inner
inline int isH0() const { return !_tctrig->pvCorr() && _tctrig->pvCode()==80; }

Expand Down

0 comments on commit 137c224

Please sign in to comment.