Remove paramiko hacks #464
Open
+8
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove two paramiko hacks done in
client.py. They both seem like very old workarounds and their functionality can be achieved through official paramiko APIs.The first one set the banner timeout for paramiko
Transportto 45 seconds.banner_timeoutcan be set in paramikoSSHClient.connector withTransport.banner_timeout, I went withconnectas it seems to be the expected way to do it. This might be a breaking change if someone is using the SSHLibrarySSHClient.clientdirectly as then the timeout will be the default 15 seconds.The second one is a workaround for
%symbols in file paths reported in 2012: http://code.google.com/p/robotframework-sshlibrary/issues/detail?id=55 . It seems this has been fixed in paramiko in 2014 here: paramiko/paramiko@6e9abc3 . As it has been fixed for so long I hope everyone moved on to newer paramiko and this is not needed anymore.Also removed small remaining Python 2 compatibility.