Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #261 #267

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed tests and generated error messages
Simandan Andrei Cristian committed Oct 8, 2018
commit c3ee58e6a3f99aac6f540d44d13fc142e78987a0
8 changes: 4 additions & 4 deletions atest/login.robot
Original file line number Diff line number Diff line change
@@ -31,15 +31,15 @@ Login With Public Key When Valid Credentials
Login With Public Key ${KEY USERNAME} ${KEY} ${PASSPHRASE}

Login With Public Key When Invalid Username
Run Keyword And Expect Error SSHException: not a valid OPENSSH private key file
Run Keyword And Expect Error Login with public key failed for user 'invalidusername'.
... Login With Public Key ${INVALID USERNAME} ${KEY}

Login With Public Key When Invalid Key
Run Keyword And Expect Error SSHException: not a valid OPENSSH private key file
... Login With Public Key ${KEY USERNAME} ${INVALID KEY} ${PASSPHRASE}
Run Keyword And Expect Error Login with public key failed for user 'testkey'.
... Login With Public Key ${KEY USERNAME} ${INVALID KEY}

Login With Public Key When Invalid Key And Valid Password
Run Keyword And Expect Error SSHException: not a valid OPENSSH private key file
Run Keyword And Expect Error Login with public key failed for user 'test'.
... Login With Public Key ${USERNAME} ${INVALID KEY} ${PASSWORD}

Login With Public Key When Non-Existing Key
2 changes: 1 addition & 1 deletion src/SSHLibrary/pythonclient.py
Original file line number Diff line number Diff line change
@@ -82,7 +82,7 @@ def _login_with_public_key(self, username, key_file, passphrase, allow_agent, lo
allow_agent=allow_agent,
look_for_keys=look_for_keys,
timeout=float(self.config.timeout))
except paramiko.AuthenticationException:
except (paramiko.AuthenticationException, paramiko.SSHException):
raise SSHClientException

def get_banner(self):