Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python tester to allow a requirements file #7383

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
2 changes: 2 additions & 0 deletions Changelog.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the master branch has been updated, there is a spacing issue with the two items under New Features and improvements. Could you please add a new line under the title New features and improvements and remove the new line above your PR item.

Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@
### 🚨 Breaking changes

### ✨ New features and improvements

- Fix front-end content shift when an input element is focused (#7384)
- Tooltip text for Package requirements file for Python autotester settings (#7383)

### 🐛 Bug fixes

Expand Down
4 changes: 4 additions & 0 deletions app/assets/stylesheets/common/_react_json_schema_form.scss
Original file line number Diff line number Diff line change
Expand Up @@ -176,4 +176,8 @@
margin-left: 170px;
padding: 0.25em 0.5em;
}

.pip_requirements_file_title:hover {
cursor: help;
}
}
10 changes: 10 additions & 0 deletions app/javascript/Components/autotest_manager.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,16 @@ class AutotestManager extends React.Component {
pip_requirements: {
"ui:widget": "textarea",
},
pip_requirements_file: {
"ui:title": (
<div
className="pip_requirements_file_title"
title={I18n.t("automated_tests.requirements_file_tooltip")}
>
{I18n.t("automated_tests.requirements_file")}
</div>
),
},
},
test_data: {
items: {
Expand Down
2 changes: 2 additions & 0 deletions config/locales/views/automated_tests/en.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@ en:
no_instructor_runnable_tests: No tests are available for instructors to run.
no_results: No test results to display
no_student_runnable_tests: No tests are available for students to run.
requirements_file: Package requirements file
requirements_file_tooltip: Upload a requirements file along with the test files
results:
extra_malformed: "Malformed results discarded by server: \n%{extra}\n"
extra_stderr: "Messages on stderr: \n%{extra}\n"
Expand Down
1 change: 1 addition & 0 deletions doc/markus-contributors.txt
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,7 @@ Rathusshan Kuganesan
Razvan Vlaicu
Rebecca Frailich
Rhys Rustad-Elliott
Ricky Chen
Robert Burke
Robert Tan
Ryan Spring
Expand Down