-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Ubuntu 22.04 and Ruby3 #6672
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 5732108720
💛 - Coveralls |
david-yz-liu
reviewed
Aug 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pretendWhale great thanks for the update.
- I was able to run the migrations without error. Feel free to put in the error message you were seeing (if it's still happening).
- I rolled back several unnecessary package updates. As far as I could tell the only one that was required for Ruby 3.0 was rqrcode (which I kept).
- When I seeded the database I did get an error related to the scanned exams:
NoMethodError: undefined method `quality=' for #<ExamTemplate id: 1, filename: "midterm1-v2-test.pdf", num_pages: 6, created_at: "2023-08-01 15:15:18.280322999 -0400", updated_at: "2023-08-01 15:15:18.280322999 -0400", name: "midterm1-v2-test", cover_fields: "", automatic_parsing: false, crop_x: nil, crop_y: nil, crop_width: nil, crop_height: nil, assessment_id: 10>
/app/app/models/exam_template.rb:246:in `block in save_cover'
/app/app/models/exam_template.rb:245:in `from_blob'
/app/app/models/exam_template.rb:245:in `save_cover'
/app/app/models/exam_template.rb:47:in `create_with_file'
/app/lib/tasks/scanned_exam.rake:26:in `block (2 levels) in <main>'
/app/db/seeds.rb:24:in `<main>'
Did you encounter this (and is that what you were hoping to fix with your changes to split_pdf_job.rb
)?
@david-yz-liu thanks for the review!
|
david-yz-liu
approved these changes
Aug 2, 2023
This was referenced Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Upgrade base docker image to use ubuntu 22.04 and upgrade ruby from 2.7 to 3.0
Your Changes
Description:
Upgraded to ubuntu 22.04 and ruby 3. This requires a few additional changes. In particular:
python3-dev
SortedSet
is removed in ruby3, so instances ofSortedSet
are replaced withSet
(and sorted using the builtinsort
method)Type of change (select all that apply):
Testing
Ran the test suite to ensure all tests pass, and tested functionality in the web interface
Questions and Comments (if applicable)
Checklist
Pull request to make documentation changes (if applicable)