Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDEV-34976 Server crash report broken if Galera is not loaded #3535

Closed
wants to merge 1 commit into from

Conversation

temeo
Copy link
Contributor

@temeo temeo commented Sep 20, 2024

  • The Jira issue number for this PR is: MDEV-34976

Description

The crash report terminates prematurely when Galera library was not loaded.

As a fix, check whether the provider is loaded before shutting down Galera connections.

How can this PR be tested?

No MTR test cases exist. Test by starting the server, signal the server to abort and observer crash report output.

Basing the PR against the correct MariaDB version

  • This is a new feature or a refactoring, and the PR is based against the main branch.
  • This is a bug fix, and the PR is based against the earliest maintained branch in which the bug can be reproduced.

PR quality check

  • I checked the CODING_STANDARDS.md file and my PR conforms to this where appropriate.
  • For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves.

The crash report terminates prematurely when Galera library was
not loaded.

As a fix, check whether the provider is loaded before shutting down
Galera connections.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@janlindstrom janlindstrom added the Codership Codership Galera label Sep 23, 2024
@sysprg
Copy link
Contributor

sysprg commented Sep 26, 2024

Thanks, the fix has been merged with the head revision: b2429e2

@sysprg sysprg closed this Sep 26, 2024
@temeo temeo deleted the 10.5-MDEV-34976 branch September 27, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Codership Codership Galera
Development

Successfully merging this pull request may close these issues.

4 participants