MDEV-34909 DDL hang during SET GLOBAL innodb_log_file_size on PMEM #3533
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Executing a DDL operation concurrently with
SET GLOBAL innodb_log_file_size
could lead to a hang of most InnoDB threads.log_t::persist()
: Add a parameter holding_latch to specify whether the caller is already holding exclusivelog_sys.latch
, likelog_write_and_flush()
always is.Release Notes
Executing a DDL operation concurrently with
SET GLOBAL innodb_log_file_size
whenib_logfile0
resides on amount -o dax
file system (persistent memory mapped log) could lead to a hang of most InnoDB threads.How can this PR be tested?
Build with
CMAKE_CXX_FLAGS
including-DLOG_LATCH_DEBUG
.Basing the PR against the correct MariaDB version
main
branch.PR quality check