MDEV-34316 Ignore the NOCOPY keyword in stored routine parameters when sql_mode=ORACLE

[wong-github1]

• *The Jira issue number for this PR is: MDEV-34316

Description

During sql_mode=ORACLE, ignore the NOCOPY keyword in stored routineparameters. The optimization (pass-by-reference instead of pass-by-value) helping to avoid value copying will be done in a separate task when needed.

Release Notes

Ignore the NOCOPY keyword in stored routine parameters when sql_mode=ORACLE

How can this PR be tested?

mysql-test/mtr sp-ignore_nocopy

Basing the PR against the correct MariaDB version

• This is a new feature or a refactoring, and the PR is based against the main branch.
• This is a bug fix, and the PR is based against the earliest maintained branch in which the bug can be reproduced.

PR quality check

• I checked the CODING_STANDARDS.md file and my PR conforms to this where appropriate.
• For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves.

[CLAassistant]

All committers have signed the CLA.

[LinuxJedi]

Hi @wong-github1,

Unfortunately this is causing test failures, this is because the NOCOPY keyword is also used for ALTER TABLE, for example:

ALTER TABLE t1 MODIFY d DOUBLE DEFAULT 10, ALGORITHM=NOCOPY

[wong-github1]

Hi @wong-github1,

Unfortunately this is causing test failures, this is because the NOCOPY keyword is also used for ALTER TABLE, for example:

ALTER TABLE t1 MODIFY d DOUBLE DEFAULT 10, ALGORITHM=NOCOPY

Hi @LinuxJedi (Andrew),

Thank you so much in pointing out the error. I have just fixed it.

[LinuxJedi]

Many thanks for fixing that, I'll hand over to @abarkov for final review.

[FooBarrior]

Hello @wong-github1! Thank you for your efforts.

For the ORACLE compatibility mode we have an compat/oracle suite. I think you can put your tests in the sp-param.test file in that suite.

Also I think we can avoid an extra switch in your ALTER TABLE fix. Can you please update it according to my suggestion?

Kind regards.

[wong-github1]

Hi @FooBarrior ,
Thanks for your review. I have made the corresponding revision.
Need your help to review again and once again, thank you.

[FooBarrior]

Hello again @wong-github1!

Our QA has found a bug within this patch: MDEV-35229. Can you please take a look?

The bug is serious and the priority is high, so would be nice if you can take a look as soon as possible.

If any questions, reach me out in MariaDB's zulip:
https://mariadb.zulipchat.com/#user/127697

Best regards

Nikita