Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aria - correct type #3516

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Aria - correct type #3516

merged 2 commits into from
Sep 20, 2024

Conversation

grooverdan
Copy link
Member

  • The Jira issue number for this PR is: MDEV-______

Description

Aria transaction ids are uint16 rather than uint.

Change the type to be more accurate.

Release Notes

Non-impacting - nothing required

How can this PR be tested?

Existing mtr tests cover it.

Basing the PR against the correct MariaDB version

  • This is a new feature or a refactoring, and the PR is based against the main branch.
  • This is a bug fix, and the PR is based against the earliest maintained branch in which the bug can be reproduced.

PR quality check

  • I checked the CODING_STANDARDS.md file and my PR conforms to this where appropriate.
  • For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves.

@grooverdan
Aria - correct type
d2333f8 
Aria transaction ids are uint16 rather than uint.

Change the type to be more accurate.
LinuxJedi
LinuxJedi approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@LinuxJedi LinuxJedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@grooverdan grooverdan enabled auto-merge (rebase) September 20, 2024 22:47
@grooverdan grooverdan merged commit ac5cbaf into MariaDB:10.6 Sep 20, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinuxJedi LinuxJedi LinuxJedi approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grooverdan @LinuxJedi