heap-buffer-overflow in mariadb-backup

write of NULL ptr after the end of the allocated buffer
MariaDB · Jan 9, 2025 · 9ddecc2 · 9ddecc2
1 parent 90bd638
commit 9ddecc2
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/extra/mariabackup/encryption_plugin.cc b/extra/mariabackup/encryption_plugin.cc
@@ -218,9 +218,10 @@ void encryption_plugin_prepare_init(int argc, char **argv)
     opt_plugin_dir[FN_REFLEN - 1] = '\0';
   }
 
-  char **new_argv = new char *[argc + 1];
+  char **new_argv = new char *[argc + 2];
   new_argv[0] = XTRABACKUP_EXE;
   memcpy(&new_argv[1], argv, argc*sizeof(char *));
+  new_argv[argc+1]= 0;
 
   encryption_plugin_init(argc+1, new_argv);