healthcheck correct connect result #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grooverdan
force-pushed
the
health_check_false_connect
branch
from
b27c8a0
to
2b6af7b
Compare
grooverdan
force-pushed
the
health_check_false_connect
branch
from
1e2e696
to
ce0afb8
Compare
Based on user reports, a `connect` test can observer a non-"Can't connect" error message. Because this passes other tests, like innodb_initialized might succeeded. The final test -z "$connect_s" is also true, leaving the user with an incorrect test result. Maybe the healthcheck cnf hasn't been created yet? Either way, ruggardise the final test to ensure a healthy connect test occured. Narrow down the scope of healthcheck --connect failures to the mariadb client errors "Can't connect". May as well look at same @skip-networking system variable on TCP just in case. 28000 errors, per https://mariadb.com/kb/en/mariadb-error-code-reference/ are client errors after a connection, indicating that the start of a tcp connection occured. Closes MariaDB#610
grooverdan
force-pushed
the
health_check_false_connect
branch
from
6bfad23
to
8997278
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on user reports, a
connecttest can observer a non-"Can't connect" error message.Because this passes other tests, like innodb_initialized might succeeded.
The final test -z "$connect_s" is also true, leaving the user with an incorrect test result.
Maybe the .my-healthcheck cnf isn't fully written yet?
Either way, ruggardize the final test to ensure a healthy connect test occurred.
Closes #610