Use MARIADB_AUTO_UPGRADE=1 to recreate healthcheck users cnf file mis… #556
Conversation
…sings Factor our create_healthcheck_users. Make sure that when recreating users, if they already exist, we just password reset these and ensure the .my-healtcheck.cnf file is there for usage. We don't want to clobber any existing grants if we happen not to have MARIADB_HEALTHCHECK_GRANTS set. Because creating users needs to move past --skip-grant-tables with FLUSH PRIVEGES, and mariadb-upgrade also issue FLUSH PRIVILEGES, then unfortunately is yet another restart. Adjust test case to ensure there is no .cnf file, and create it on restore.
|
@tanji I'm having trouble finding people willing to review these kind of changes, so if you have time your input would be appreciated. |
There was a problem hiding this comment.
@grooverdan sorry for the delay. It's a bit difficult for me to review something else than the bash code that looks OK.
I am missing (or not understanding) the scenario to test this. It may be something we should test in the CI also, the entrypoint is becoming quite big so, it would really help to have a bunch of unit tests automatically executed in the CI.
When The .test/run.sh does this ensuring the file is missing, and performs a
like pre-merge - rather than https://buildbot.mariadb.org/#/builders/311/builds/21042/steps/3/logs/stdio, probably right.
ok. |
…sings
Factor our create_healthcheck_users.
Make sure that when recreating users, if they already exist, we just password reset these and ensure the .my-healtcheck.cnf file is there for usage. We don't want to clobber any existing grants if we happen not to have MARIADB_HEALTHCHECK_GRANTS set.
Because creating users needs to move past --skip-grant-tables with FLUSH PRIVILEGES, and mariadb-upgrade also issue FLUSH PRIVILEGES, then unfortunately is yet another restart.
@NiroDeveloper in #515 you wanted healthcheck user and an easy path, how does using MARIADB_AUTO_UPGRADE=1 (or a db restore), sound as a place to recreate those users if needed?