Update async replication example and add semisync replication example #547
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| MARIADB_ROOT_PASSWORD=secret | ||
| MARIADB_REPLICATION_USER=repl | ||
| MARIADB_REPLICATION_PASSWORD=replicationpass | ||
| PRIMARY_name='mariadb-primary' | ||
| REPLICATION_name_1='mariadb-replica-1' | ||
| REPLICATION_name_2='mariadb-replica-2' | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| version: "3" | ||
| x-common-variables: &common-variables | ||
| MARIADB_ROOT_PASSWORD: ${MARIADB_ROOT_PASSWORD} | ||
| MARIADB_REPLICATION_USER: ${MARIADB_REPLICATION_USER} | ||
| MARIADB_REPLICATION_PASSWORD: ${MARIADB_REPLICATION_PASSWORD} | ||
|
|
||
| x-common-attributes: &common-attributes | ||
| env_file: | ||
| - .env | ||
|
There was a problem hiding this comment. in preparation for non-replication based examples here, recommend explicit naming about What's the gain on having it as an env file? It it just showcasing the hiding of passwords out of the main compose file as best practices? There was a problem hiding this comment. The gain as you said for password and having it in place and not repeating the variables for different containers. |
||
| image: mariadb:lts | ||
| environment: *common-variables | ||
| healthcheck: | ||
| test: ["CMD", "healthcheck.sh", "--connect", "--innodb_initialized"] | ||
| start_period: 10s | ||
| interval: 10s | ||
| timeout: 5s | ||
| retries: 3 | ||
|
|
||
| x-common-replication: &common-replication | ||
| healthcheck: | ||
| test: ["CMD", "healthcheck.sh", "--connect", "--replication_io", "--replication_sql", "--replication_seconds_behind_master=1", "--replication"] | ||
| interval: 10s | ||
| timeout: 5s | ||
| retries: 3 | ||
|
There was a problem hiding this comment. is start_period worth including and works correctly?10s? There was a problem hiding this comment. Yes it works, have added, thanks. There is also start_interval, but I wouldn't added it here. |
||
| depends_on: | ||
| master: | ||
| condition: service_healthy | ||
|
|
||
| services: | ||
| master: | ||
| <<: *common-attributes | ||
| container_name: ${PRIMARY_name} | ||
| command: --log-bin --log-basename=mariadb --rpl_semi_sync_master_enabled | ||
| environment: | ||
| - MARIADB_USER=testuser | ||
| - MARIADB_PASSWORD=password | ||
| - MARIADB_DATABASE=testdb | ||
|
|
||
| replica1: | ||
| <<: | ||
| - *common-attributes | ||
| - *common-replication | ||
| container_name: ${REPLICATION_name_1} | ||
| command: --server-id=2 --log-basename=mariadb --rpl_semi_sync_slave_enabled | ||
| environment: | ||
|
There was a problem hiding this comment. can There was a problem hiding this comment. No, we can not move |
||
| - MARIADB_MASTER_HOST=${PRIMARY_name} | ||
| - MARIADB_HEALTHCHECK_GRANTS=REPLICA MONITOR | ||
|
|
||
| replica2: | ||
| <<: | ||
| - *common-attributes | ||
| - *common-replication | ||
| container_name: ${REPLICATION_name_2} | ||
| command: --server-id=3 --log-basename=mariadb --rpl_semi_sync_slave_enabled | ||
| environment: | ||
| - MARIADB_MASTER_HOST=${PRIMARY_name} | ||
| - MARIADB_HEALTHCHECK_GRANTS=REPLICA MONITOR | ||
|
|
||
| networks: | ||
| backend: | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,34 +1,60 @@ | ||
| version: "3" | ||
| x-common-variables: &common-variables | ||
| MARIADB_ROOT_PASSWORD: ${MARIADB_ROOT_PASSWORD} | ||
| MARIADB_REPLICATION_USER: ${MARIADB_REPLICATION_USER} | ||
| MARIADB_REPLICATION_PASSWORD: ${MARIADB_REPLICATION_PASSWORD} | ||
|
|
||
| x-common-attributes: &common-attributes | ||
| env_file: | ||
| - .env | ||
| image: mariadb:lts | ||
| environment: *common-variables | ||
| healthcheck: | ||
| test: ["CMD", "healthcheck.sh", "--connect", "--innodb_initialized"] | ||
| start_period: 10s | ||
| interval: 10s | ||
| timeout: 5s | ||
| retries: 3 | ||
|
|
||
| x-common-replication: &common-replication | ||
| healthcheck: | ||
| test: ["CMD", "healthcheck.sh", "--connect", "--replication_io", "--replication_sql", "--replication_seconds_behind_master=1", "--replication"] | ||
| interval: 10s | ||
| timeout: 5s | ||
| retries: 3 | ||
| depends_on: | ||
| master: | ||
| condition: service_healthy | ||
|
|
||
| services: | ||
| master: | ||
| <<: *common-attributes | ||
| container_name: ${PRIMARY_name} | ||
| command: --log-bin --log-basename=mariadb | ||
| environment: | ||
| - MARIADB_USER=testuser | ||
| - MARIADB_PASSWORD=password | ||
| - MARIADB_DATABASE=testdb | ||
|
|
||
| replica1: | ||
| <<: | ||
| - *common-attributes | ||
| - *common-replication | ||
| container_name: ${REPLICATION_name_1} | ||
| command: --server-id=2 --log-basename=mariadb | ||
| environment: | ||
| - MARIADB_MASTER_HOST=${PRIMARY_name} | ||
| - MARIADB_HEALTHCHECK_GRANTS=REPLICA MONITOR | ||
|
|
||
| replica2: | ||
| <<: | ||
| - *common-attributes | ||
| - *common-replication | ||
| container_name: ${REPLICATION_name_2} | ||
| command: --server-id=3 --log-basename=mariadb | ||
| environment: | ||
| - MARIADB_MASTER_HOST=${PRIMARY_name} | ||
| - MARIADB_HEALTHCHECK_GRANTS=REPLICA MONITOR | ||
|
|
||
| networks: | ||
| backend: |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
REPLICATION_*are only used once. Can we just omit them and get the default configuration.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are here giving the exact name of replicas, I personally prefer to specify the name of replicas.