-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install rocksdb plugin #486
base: master
Are you sure you want to change the base?
Conversation
Yes, also see: https://mariadb.org/installing-plugins-in-the-mariadb-docker-library-container/ There's a big tradeoff between basic images and all plugins. There was some discussion about making a separate image layer for plugins like RocksDB. |
This makes total sense. Thank you. The link describes different ways of enabling plugins that already baked into the image, but not loaded/enabled by default. The problem with the rocksdb one, it's not in the image, so even if user wants it to be loaded and enabled, they cannot do this, as the plugin (so file) does not exist in the image. This PR basically installs the plugin into the image. This increases the image size by ~6.7MB, it's just 1% of the overall image size - 481MB. The problem was, it was installed upon server startup (because the package adds a config file with plugin installation), I've modified the Docker file to remove the file from the image, so now, it does not get installed on the server start up, but can be installed by user.
|
@ifel good points. Thanks for measuring. |
RocksDB engine is officially supported by MariaDB (https://mariadb.com/kb/en/getting-started-with-myrocks/), but the image does not have the plugin installed. Install it, so users will be able to load it if it's needed.