MDBF-807 - Setup for PAM tests in buildbot #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
RazvanLiviuVarzaru
commented
Oct 22, 2024
•
RazvanLiviuVarzaru
commented
- configure install builders to perform PAM tests. RPM and DEB.
- migrate pam test script from old - bb:
- no need to create a new user. We have buildbot user.
- PAM v1 & v2 are configured and the auth is tested with the buildbot user.
- the user should not be able to login after the plugin is uninstalled
- perform MTR pam test in suite=plugins
RazvanLiviuVarzaru
force-pushed
the
feature/pam
branch
2 times, most recently
from
5c201f3
to
8bed003
Compare
- configure install builders to perform PAM tests. RPM and DEB. - migrate pam test script from old - bb: - no need to create a new user. We have buildbot user. - PAM v1 & v2 are configured and the auth is tested with the buildbot user. - the user should not be able to login after the plugin is uninstalled - perform MTR pam test in suite=plugins
RazvanLiviuVarzaru
force-pushed
the
feature/pam
branch
from
8bed003
to
c7978a9
Compare
vladbogo
approved these changes
Oct 22, 2024
fauust
reviewed
Oct 24, 2024
fauust
reviewed
Oct 24, 2024
fauust
requested changes
Oct 24, 2024
| # MTR | ||
| #---------------- | ||
|
|
||
| cd /usr/share/mysql-test || cd /usr/share/mariadb-test || cd /usr/share/mysql/mysql-test || cd /usr/share/mariadb/mariadb-test |
There was a problem hiding this comment.
hmm this is confusing an does not look clean, what about something like:
# PATH can differ between MariaDB versions and distros
for db in mysql mariadb; do
for dir in \
/usr/share/$db-test \
/usr/share/$db/$db-test; do
[[ -d "$dir" ]] && cd "$dir"
done
doneThere was a problem hiding this comment.
Sure, I'll try it out. Much cleaner, thanks!
|
|
||
| cd /usr/share/mysql-test || cd /usr/share/mariadb-test || cd /usr/share/mysql/mysql-test || cd /usr/share/mariadb/mariadb-test | ||
|
|
||
| if test -f suite/plugins/pam/pam_mariadb_mtr.so; then |
There was a problem hiding this comment.
Old syntax and not efficient, use bash builtin commands:
if [[ -f suite/plugins/pam/pam_mariadb_mtr.so ]]; then
[...]
fiSee: https://google.github.io/styleguide/shellguide.html#test----and---
There was a problem hiding this comment.
Thanks, will fix!
|
|
||
| if test -f suite/plugins/pam/pam_mariadb_mtr.so; then | ||
| for p in /lib*/security /lib*/*/security ; do | ||
| test -f "$p/pam_unix.so" && sudo cp -v suite/plugins/pam/pam_mariadb_mtr.so "$p"/ |
There was a problem hiding this comment.
same comment:
[[ -f "$p/pam_unix.so" ]] && sudo cp -v suite/plugins/pam/pam_mariadb_mtr.so "$p"/|
|
||
| set +e | ||
|
|
||
| if [ "$res" != "0" ] ; then |
There was a problem hiding this comment.
Numerical comparison is done with the following:
if ((res != 0)); then
[...]
fisee: https://google.github.io/styleguide/shellguide.html#testing-strings
However, be careful when using < and > in [[ … ]] which performs a lexicographical comparison. Use (( … )) or -lt and -gt for numerical comparison.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.