Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDBF-800][Postfix] - fix minor upgrade all #596

Merged
merged 10 commits into from
Oct 18, 2024

Conversation

RazvanLiviuVarzaru
Copy link
Collaborator

@RazvanLiviuVarzaru RazvanLiviuVarzaru commented Oct 16, 2024

  • MDBF-803 - fixed finding mirror packages for previous OpenSuse 15.5/15.6 and CentosStream9
  • add libmecab-dev to sort out LDD, REQ differences for mariadb-plugin-mroonga
  • temporary adjustments for libaio/liburing and lsof to sort out the differences until Q4 release is done
  • Account for mariadb-plugin-mroonga diffs in Debian-11
  • fix upgrade script for OpenSuse - cache, install command, gpg key
  • remove building compat for OpenSuse/SLES 15.x

…PM repo on {archive/mirror}.mariadb.org

Exception: centos >= 9 which should be sorted out! (relative path on mirrors centos/$version/$platform)

Build_arch is used as $arch in bash_lib.sh, rpm_setup_mariadb_mirror{} to calculate mirror/archive URL.
…it as REQUIRED hence minor upgrades (all) will reflect the change during verifications.

> 10.5 MariaDB releases use liburing. Q3 release was linked against libaio which accounts for the differences found during testing.
@RazvanLiviuVarzaru RazvanLiviuVarzaru marked this pull request as ready for review October 16, 2024 08:34
@fauust
Copy link
Collaborator

fauust commented Oct 16, 2024

Looks good but I am wondering if we should not store the ajustements in a dedicated file, it would be easier to track and probably easier to maintain. Also, the bash library is used everywhere, when possible it's good to not touch it :)

So, something like:

for lib in grep -v "^\#" cmp_ajustements.txt; do
  sed -i '/\$lib/d' ./reqs-*.cmp
done

(not tested)

Finally and ideally, we should find an automated way of being alerted that something needs to be changed. I don't have good suggestion for now (I am referring to https://github.com/MariaDB/buildbot/pull/596/files#diff-42cf97a1c42ac653cd754c87e9a83639e18cd70cb19bef6c880dd98d3da7b701R575).

@RazvanLiviuVarzaru
Copy link
Collaborator Author

Looks good but I am wondering if we should not store the ajustements in a dedicated file, it would be easier to track and probably easier to maintain. Also, the bash library is used everywhere, when possible it's good to not touch it :)

So, something like:

for lib in grep -v "^\#" cmp_ajustements.txt; do
  sed -i '/\$lib/d' ./reqs-*.cmp
done

(not tested)

Finally and ideally, we should find an automated way of being alerted that something needs to be changed. I don't have good suggestion for now.

@fauust Most of the temporary adjustments are build environment differences between old/new bb so will be removed at some point. I will give the cmp_ajustements file a thought. For now I think it's better if we get the builds running and afterwards we can refactor.

- cache location is zypp
- "all" does not exist for clearing cache, instead zypper uses --all
-  when MariaDB.repo is first added the key should be trusted in a non-interactive manner, hence --gpg-auto-import-keys
- first zypper packages -r goes to /dev/null because there is a lot of noise from trusting the key. Sudo is needed to make the cache.
- second zypper packages -r runs as a normal user with no issues.
Copy link
Collaborator

@fauust fauust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, but try to address the /dev/null thing.

scripts/bash_lib.sh Outdated Show resolved Hide resolved
scripts/rpm-upgrade.sh Outdated Show resolved Hide resolved
@RazvanLiviuVarzaru RazvanLiviuVarzaru merged commit bd24e54 into MariaDB:dev Oct 18, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants