-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jepsen mariadb fixes #498
Jepsen mariadb fixes #498
Conversation
As lein is important part of the build it should be built into the container. The building from source isn't a good idea as we can use a pre-build binary. This is supported in the project already - MariaDB/jepsen-mariadb@7baa716 but requires a manual hack to change from the base debian-12 that is assumed.
|
Running for apt-get installed packages (I did distro ones however ci base repo of https://ci.mariadb.org/47558/amd64-ubuntu-2004-deb-autobake/mariadb.sources is just as good). Using packages means:
Code diff:
run as bb user:
|
# Clone the jepsen-mysql repository, download leiningen, and set permissions | ||
RUN git clone https://github.com/vlad-lesin/jepsen-mysql jepsen-mariadb \ | ||
# Clone the jepsen-mariadb repository, download leiningen, and set permissions | ||
RUN git clone https://github.com/MariaDB/jepsen-mariadb jepsen-mariadb \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pins the scripts to the repository version at the time of image build.
Is this the desired behavior?
If not, at least a Pull should happen during a BB-Build or git clone to be moved out of dockerfile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understood that's the desired behaviour, but we can add a git pull in a step if it needs to be updated. The files are needed during image creation
Template selection
Please go the the
Preview
tab and select the appropriate sub-template: