Add amd64-debian-12-asan-ubsan #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grooverdan
reviewed
Sep 20, 2023
| @@ -222,6 +222,9 @@ addWorker('hz-bbw', 1, '-msan-clang-debian-11', "quay.io/mariadb-foundation/bb-w | |||
| addWorker('hz-bbw', 4, '-msan-clang-debian-11', "quay.io/mariadb-foundation/bb-worker:debian11-msan", jobs=20, save_packages=False) | |||
| addWorker('hz-bbw', 5, '-msan-clang-debian-11', "quay.io/mariadb-foundation/bb-worker:debian11-msan", jobs=30, save_packages=False) | |||
|
|
|||
| addWorker('hz-bbw', 2, '-debian-12', "quay.io/mariadb-foundation/bb-worker:debian12", jobs=20, save_packages=False) | |||
| addWorker('hz-bbw', 5, '-debian-12', "quay.io/mariadb-foundation/bb-worker:debian12", jobs=20, save_packages=False) | |||
There was a problem hiding this comment.
shouldn't these have a -asan-ubsan suffix on the worker image name?
On worker name might be good for searchability too.
There was a problem hiding this comment.
from a manual run that seemed to work, there are no additional packages needed, so we can use the base debian12 image for the asan and ubsan
master-docker-nonstandard/master.cfg
Outdated
| @@ -672,6 +702,16 @@ c['builders'].append( | |||
| locks=getLocks, | |||
| factory=f_without_server)) | |||
|
|
|||
| c['builders'].append( | |||
| util.BuilderConfig(name="amd64-debian-12-asan-ubsan", | |||
| workernames=workers["x64-bbw-docker-debian-12"], | |||
There was a problem hiding this comment.
would need to change if worker does.
|
It uses the base Debian 12 image since there doesn't seem to be anything missing from it |
vladbogo
force-pushed
the
add_asan_ubsan_builder
branch
from
0377c33
to
d799735
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.