Skip to content

Commit

Permalink
fix order
Browse files Browse the repository at this point in the history
  • Loading branch information
MarcoGorelli committed Oct 25, 2024
1 parent 23e35fa commit c3f7135
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion narwhals/_pandas_like/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -607,5 +607,5 @@ def reset_index_no_copy(native_dataframe: pd.DataFrame, native_namespace: Any) -
msg = f"Cannot insert column with name {native_dataframe.index.name} into dataframe with columns {native_dataframe.columns}"
raise ValueError(msg)
for i, name in enumerate(native_dataframe.index.names):
native_dataframe[name] = native_dataframe.index.get_level_values(i)
native_dataframe.insert(0, name, native_dataframe.index.get_level_values(i))
native_dataframe.index = native_namespace.RangeIndex(len(native_dataframe))
2 changes: 1 addition & 1 deletion tests/utils_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ def test_reset_index_no_copy() -> None:
df = pd.DataFrame({"a": [1, 2, 3], "b": [4.0, 5.0, 6.0]}).set_index("a")
reset_index_no_copy(df, pd)
pd.testing.assert_frame_equal(
df, pd.DataFrame({"b": [4.0, 5.0, 6.0], "a": [1, 2, 3]})
df, pd.DataFrame({"a": [1, 2, 3], "b": [4.0, 5.0, 6.0]})
)
df.index.name = "b"
with pytest.raises(ValueError, match="Cannot insert column"):
Expand Down

0 comments on commit c3f7135

Please sign in to comment.