Skip to content

Commit

Permalink
fixup
Browse files Browse the repository at this point in the history
  • Loading branch information
MarcoGorelli committed Oct 29, 2024
1 parent 80630a6 commit 4efb645
Showing 1 changed file with 18 additions and 7 deletions.
25 changes: 18 additions & 7 deletions .github/workflows/downstream_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ jobs:
matrix:
python-version: ["3.12"]
os: [ubuntu-latest]
# temporarily commented out due to flaky tests
dependencies: ["core", "core,optional"]

runs-on: ${{ matrix.os }}
Expand All @@ -74,21 +73,27 @@ jobs:
run: |
git clone https://github.com/marimo-team/marimo.git --depth=1
cd marimo
uv venv -p 3.12
git log
- name: install-basics
run: uv pip install --upgrade tox virtualenv setuptools hatch --system
- name: install-marimo-dev
run: |
cd marimo
uv pip install -e ".[dev]" --system
. .venv/bin/activate
uv pip install -e ".[dev]"
which python
- name: install-narwhals-dev
run: |
uv pip uninstall narwhals --system
uv pip install narwhals==1.10.0 --system # temporary
# uv pip install -e . --system
cd marimo
. .venv/bin/activate
uv pip uninstall narwhals
uv pip install -e .
- name: show-deps
run: uv pip freeze
run: |
cd marimo
. .venv/bin/activate
uv pip freeze
- name: Create assets directory, copy over index.html
continue-on-error: true
run: |
Expand All @@ -99,11 +104,17 @@ jobs:
if: ${{ matrix.dependencies == 'core,optional' }}
run: |
cd marimo
HATCH_ENV_DEFAULT_PATH=$(which python) hatch run test-optional:test-narwhals
. .venv/bin/activate
# make sure that we use the .venv when running tests, so that
# the local narwhals install is picked up
sed -i '/^\[tool.hatch.envs.default\]/a path = ".venv"' pyproject.toml
hatch run python -c "import narwhals; print(narwhals.__file__)"
hatch run test-optional:test-narwhals
timeout-minutes: 15
- name: Run typechecks
run: |
cd marimo
. .venv/bin/activate
hatch run typecheck:check
scikit-lego:
Expand Down

0 comments on commit 4efb645

Please sign in to comment.