Skip to content

Commit

Permalink
raise notimplemetederror instead of typeerror
Browse files Browse the repository at this point in the history
  • Loading branch information
raisadz committed Dec 29, 2024
1 parent bd262d0 commit 364ae0d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions narwhals/_duckdb/expr.py
Original file line number Diff line number Diff line change
Expand Up @@ -617,7 +617,7 @@ def replace_all(
from duckdb import FunctionExpression

if literal is False:
msg = "Only `literal=True` is currently supported."
msg = "`replace_all` for DuckDB currently only supports `literal=True`."
raise NotImplementedError(msg)
return self._compliant_expr._from_call(
lambda _input: FunctionExpression(
Expand All @@ -632,7 +632,7 @@ def replace_all(

def replace(self, pattern: str, value: str, *, literal: bool, n: int) -> NoReturn:
msg = "`replace` is currently not supported for DuckDB"
raise TypeError(msg)
raise NotImplementedError(msg)


class DuckDBExprDateTimeNamespace:
Expand Down

0 comments on commit 364ae0d

Please sign in to comment.