-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Label Designer & Repository Transfer #6
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+178
to
+199
* SPLIT ls_settings-labels AT ',' INTO TABLE lt_labels. | ||
* | ||
* LOOP AT s_label ASSIGNING <lv_label>. | ||
* lv_label = condense( <lv_label>-low ). | ||
* READ TABLE lt_labels TRANSPORTING NO FIELDS WITH KEY table_line = lv_label. | ||
* IF sy-subrc <> 0 AND p_add = abap_true. | ||
* INSERT lv_label INTO TABLE lt_labels. | ||
* ELSEIF sy-subrc = 0 AND p_remove = abap_true. | ||
* DELETE lt_labels WHERE table_line = lv_label. | ||
* ENDIF. | ||
* ENDLOOP. | ||
* | ||
* CONCATENATE LINES OF lt_labels INTO lv_label SEPARATED BY ','. | ||
* | ||
* ls_settings-labels = zcl_abapgit_repo_labels=>normalize( lv_label ). | ||
* | ||
* TRY. | ||
* li_repo->set_local_settings( ls_settings ). | ||
* COMMIT WORK AND WAIT. | ||
* CATCH zcx_abapgit_exception INTO lx_error. | ||
* MESSAGE lx_error TYPE 'I'. | ||
* ENDTRY. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commented code
Suggest following fix,
Suggested change
* SPLIT ls_settings-labels AT ',' INTO TABLE lt_labels. | |
* | |
* LOOP AT s_label ASSIGNING <lv_label>. | |
* lv_label = condense( <lv_label>-low ). | |
* READ TABLE lt_labels TRANSPORTING NO FIELDS WITH KEY table_line = lv_label. | |
* IF sy-subrc <> 0 AND p_add = abap_true. | |
* INSERT lv_label INTO TABLE lt_labels. | |
* ELSEIF sy-subrc = 0 AND p_remove = abap_true. | |
* DELETE lt_labels WHERE table_line = lv_label. | |
* ENDIF. | |
* ENDLOOP. | |
* | |
* CONCATENATE LINES OF lt_labels INTO lv_label SEPARATED BY ','. | |
* | |
* ls_settings-labels = zcl_abapgit_repo_labels=>normalize( lv_label ). | |
* | |
* TRY. | |
* li_repo->set_local_settings( ls_settings ). | |
* COMMIT WORK AND WAIT. | |
* CATCH zcx_abapgit_exception INTO lx_error. | |
* MESSAGE lx_error TYPE 'I'. | |
* ENDTRY. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of this is WIP