Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Label Designer & Repository Transfer #6

Merged
merged 9 commits into from
Mar 12, 2024

Conversation

mbtools
Copy link
Member

@mbtools mbtools commented Mar 12, 2024

Some of this is WIP

@mbtools mbtools merged commit 9de3c0f into Marc-Bernard-Tools:main Mar 12, 2024
2 of 3 checks passed
Comment on lines +178 to +199
* SPLIT ls_settings-labels AT ',' INTO TABLE lt_labels.
*
* LOOP AT s_label ASSIGNING <lv_label>.
* lv_label = condense( <lv_label>-low ).
* READ TABLE lt_labels TRANSPORTING NO FIELDS WITH KEY table_line = lv_label.
* IF sy-subrc <> 0 AND p_add = abap_true.
* INSERT lv_label INTO TABLE lt_labels.
* ELSEIF sy-subrc = 0 AND p_remove = abap_true.
* DELETE lt_labels WHERE table_line = lv_label.
* ENDIF.
* ENDLOOP.
*
* CONCATENATE LINES OF lt_labels INTO lv_label SEPARATED BY ','.
*
* ls_settings-labels = zcl_abapgit_repo_labels=>normalize( lv_label ).
*
* TRY.
* li_repo->set_local_settings( ls_settings ).
* COMMIT WORK AND WAIT.
* CATCH zcx_abapgit_exception INTO lx_error.
* MESSAGE lx_error TYPE 'I'.
* ENDTRY.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented code

Suggest following fix,

Suggested change
* SPLIT ls_settings-labels AT ',' INTO TABLE lt_labels.
*
* LOOP AT s_label ASSIGNING <lv_label>.
* lv_label = condense( <lv_label>-low ).
* READ TABLE lt_labels TRANSPORTING NO FIELDS WITH KEY table_line = lv_label.
* IF sy-subrc <> 0 AND p_add = abap_true.
* INSERT lv_label INTO TABLE lt_labels.
* ELSEIF sy-subrc = 0 AND p_remove = abap_true.
* DELETE lt_labels WHERE table_line = lv_label.
* ENDIF.
* ENDLOOP.
*
* CONCATENATE LINES OF lt_labels INTO lv_label SEPARATED BY ','.
*
* ls_settings-labels = zcl_abapgit_repo_labels=>normalize( lv_label ).
*
* TRY.
* li_repo->set_local_settings( ls_settings ).
* COMMIT WORK AND WAIT.
* CATCH zcx_abapgit_exception INTO lx_error.
* MESSAGE lx_error TYPE 'I'.
* ENDTRY.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant