-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update default CS and Projection for layer #854
Conversation
…ocument' metadata + fix zoom to here link for query
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, tested with geoserver too. I noticed that in mapml2geojson.html / test there are some comments like this:
<!-- Setting the geometry coordinates to gcrs, as the default is pcrs -->
<map-geometry cs="gcrs">
so maybe we should amend that test / others that we may find that set the default CS and projection via map-meta or cs attribute to RELY on the new default values for these? At least we could remove the comment because it's no longer true that the default is PCRS.
navigate from focused on-screen element in shadow root to custom element (_groupEl already allows code navigation to SD-rendered content) Add test leveraging <g>._feature property to verify rendering of default coordinate system geometries.
because they are the defaults / fallback values when not explicitly marked up.
…eta name="cs" content="gcrs" and map-meta name="projection" content="OSMTILE" Revert "Remove cs="gcrs" and <map-meta name="projection" content="OSMTILE"> " This reverts commit 3be3684. update test to use default projection and CS
I believe so, do you think the testing is sufficient or can you think of any other edge cases? I will give it a second look also. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
…tter) changes when we've resolved 'createmap' dilemma.
@prushforth in ca9399d, default projection was added, and the use of 'createmap' events was removed. Though there is still a bug with the _processInitialExtent/_initTemplateVars, this occurs when the map is initially loading and the custom projection is not available, I think the layer/extent needs to go disabled at that stage and not go through that code at that time, and the layer should only be loaded once the current projection is available with the use of 'projectionchange' events emitted by mapml-viewer, which the layer will be listening for. This will be handled in #873. |
…events" This reverts commit ca9399d.
Add default projection of "OSMTILE" to a <mapml-viewer> with no projection attribute #860handled in Add a default projection (OSMTILE) for the map #873Add web-map equivalent