Update miniAero for Kokkos 3.0 promotion. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 17, 2019 13:44
Fix CXX path to point to standard Kokkos install location for nvcc. Update KOKKOS_ARCH for more recent CUDA Compute Capability.
Fixes compiler error: cannot call member function ‘void Kokkos::<Space>::fence() const’ without object.
…s turned off. Add KOKKOS_OPTION disable_deprecated_code to Makefile. Will reset this when miniAero is fully refactored.
|
Should the Device::fence(); --> Device().fence(); changes simply become Kokkos::fence() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These updates were tested on several platforms with OpenMP, Serial, Pthreads, and Cuda backends, with clang version 3.8.1-24 and g++ 6.3.0. Let me know if we want better coverage on compilers/platforms for other miniapp updates.
Now works with deprecated_code enabled or disabled.