Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SDK Data Files and Rust Library #3

Merged
merged 23 commits into from
Feb 8, 2022
Merged

Add SDK Data Files and Rust Library #3

merged 23 commits into from
Feb 8, 2022

Conversation

bhgomes
Copy link
Contributor

@bhgomes bhgomes commented Jan 19, 2022

TODO

  • Finish parameter serialization in manta-rs to import the rest of the parameters here
  • Add rust-phf for the AssetId compile-time hash map No longer needed.
  • Add checksums
  • Setup framework to download data (part of the signer, either the build or the execution)

@bhgomes bhgomes self-assigned this Jan 19, 2022
@bhgomes bhgomes requested review from Kevingislason, stechu and a user January 24, 2022 17:55
@bhgomes bhgomes marked this pull request as ready for review January 24, 2022 17:55
@stechu
Copy link
Collaborator

stechu commented Feb 7, 2022

@bhgomes Do you think we should put the sum check to CI? (Should be done in a new PR).

@bhgomes
Copy link
Contributor Author

bhgomes commented Feb 7, 2022

@bhgomes Do you think we should put the sum check to CI? (Should be done in a new PR).

I think we should make it part of this issue: #4. Generally we want to add some CI, yes.

@stechu
Copy link
Collaborator

stechu commented Feb 7, 2022

@Kevingislason @tommyjk21 Let me know you guys' thoughts. Otherwise I am happy to merge it soon.

@bhgomes bhgomes merged commit aeed6ca into main Feb 8, 2022
@bhgomes bhgomes deleted the add-sdk-library branch February 8, 2022 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Asset ID Lists Add Parameters (Hash Parameters and Proving/Verifying Keys)
2 participants