Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump @cookbookdev/docsbot (Ask Cookbook) to 4.17.9 #270

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ClockRide
Copy link
Contributor

  • Bumped @cookbookdev/docsbot (Ask Cookbook) to 4.17.9.
  • Updated apiKey to provide more flexibility by using a dedicated portal for the documentation website. All Manta team members who joined the previous CMS portal have already been provided access to the new one as well. Please contact us at [email protected] if you work for Manta and would like access to the "Ask Cookbook" settings!

Copy link

vercel bot commented Jun 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 8, 2024 5:12am

@jincan39
Copy link
Collaborator

@ClockRide Thanks, btw please review that the huge change of yarn.lock.

@ClockRide
Copy link
Contributor Author

@ClockRide Thanks, btw please review that the huge change of yarn.lock.

Sure thing! Since the previous version, we've added a playground feature that allows users to deploy any contract from our library to Manta in just a few clicks, as well as customize it for their needs right from the browser tab! Since we compile contracts directly in the browser using solc and use monaco-react to support Solidity syntax highlighting, we have added many new dependencies as a result.

The good part, though, is that it's all lazy-loaded and tree-shaken during the bundling step, resulting in roughly a 3kb (gzip) initial bundle for your setup (see https://bundlejs.com/?q=%40cookbookdev%2Fdocsbot%404.21.0%2Freact).

I could see how bloating your yarn.lock with all this dependencies could be a concern though, even though they never end up in actual bundle. To address this, we plan to decouple the lazy-loaded version you're using from the main bundle in the future. However, for now, they are all part of the same package, and if this is a blocker, I'm happy to work with you to find a temporary workaround, so lmk if that's something you want to pursue

@jincan39
Copy link
Collaborator

@ClockRide ah i see that make sense, please rewrite your commit with a signature so that i can merge this PR, thanks.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants