-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix xcm benchmark tests #1333
Fix xcm benchmark tests #1333
Conversation
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Dengjianping <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Jamie <[email protected]>
Signed-off-by: Jamie <[email protected]>
Signed-off-by: Jamie <[email protected]>
Signed-off-by: Jamie <[email protected]>
Signed-off-by: Jamie <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
xcm fungible benchmark still fails right? does in ci
Signed-off-by: Jamie <[email protected]>
My bad, I moved asset creation after asset registration. |
Signed-off-by: Jamie <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
Signed-off-by: Jamie <[email protected]>
Description
Before we can approve this PR for merge, please make sure that all the following items have been checked off:
L-
group to this PRA-
andC-
groups to this PRA-calamari
and/orA-manta
if your changes are meant for/impact either of these (CI depends on it)Files changed
in the Github PR explorer.A-integration-test-checks
to run start-integration-test-checks (Required)A-benchmark-checks
to run start-benchmark-check (Required)A-unit-test-checks
to run start-unit-test-checks (Required)A-congestion-test-checks
to run start-integration-test-checks (Optional)Situational Notes:
BaseFilter
. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.try-runtime
. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of#[pallet::storage]
items to check for any.