Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix xcm benchmark tests #1333

Merged
merged 63 commits into from
May 18, 2024
Merged

Fix xcm benchmark tests #1333

merged 63 commits into from
May 18, 2024

Conversation

Dengjianping
Copy link
Contributor

@Dengjianping Dengjianping commented May 9, 2024

Description


Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.
  • Add A-integration-test-checks to run start-integration-test-checks (Required)
  • Add A-benchmark-checks to run start-benchmark-check (Required)
  • Add A-unit-test-checks to run start-unit-test-checks (Required)
  • Add A-congestion-test-checks to run start-integration-test-checks (Optional)

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Dengjianping and others added 8 commits April 18, 2024 18:35
Signed-off-by: Dengjianping <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Jamie <[email protected]>
Signed-off-by: Jamie <[email protected]>
@Dengjianping Dengjianping self-assigned this May 13, 2024
@Dengjianping Dengjianping added A-manta Area: Issues and PRs related to the Manta Runtime A-calamari Area: Issues and PRs related to the Calamari Runtime A-ci Area: Continuous Integration A-testing Area: Testing-related Issues and PRs L-fixed Log: Issues and PRs related to bug fixes A-benchmark-checks A-unit-test-checks A-integration-test-checks labels May 13, 2024
Signed-off-by: Jamie <[email protected]>
Signed-off-by: Jamie <[email protected]>
Copy link
Contributor

@ferrell-code ferrell-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xcm fungible benchmark still fails right? does in ci

@Dengjianping
Copy link
Contributor Author

Dengjianping commented May 15, 2024

xcm fungible benchmark still fails right? does in ci

My bad, I moved asset creation after asset registration.
Now it should be fixed.

Signed-off-by: Jamie <[email protected]>
Copy link
Contributor

@ferrell-code ferrell-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Signed-off-by: Jamie <[email protected]>
@Dengjianping Dengjianping merged commit faaf9dc into manta May 18, 2024
20 checks passed
@Dengjianping Dengjianping deleted the fix-xcm-benchmark-tests branch May 18, 2024 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-benchmark-checks A-calamari Area: Issues and PRs related to the Calamari Runtime A-ci Area: Continuous Integration A-integration-test-checks A-manta Area: Issues and PRs related to the Manta Runtime A-testing Area: Testing-related Issues and PRs A-unit-test-checks L-fixed Log: Issues and PRs related to bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants