Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 arc runner migration patch 2.1 #1242

Merged
merged 19 commits into from
Aug 22, 2023
Merged

Conversation

anaye1997
Copy link
Contributor

@anaye1997 anaye1997 commented Aug 2, 2023

Description

this change

  • updates `Run tests` pipeline to use org arc runner
  • adds Swatinem/rust-cache@v2 for cacheing rust package
  • make below job to be triggered by label
    • Add A-integration-test-checks to run start-integration-test-checks (Required)
    • Add A-benchmark-checks to run start-benchmark-check (Required)
    • Add A-unit-test-checks to run start-unit-test-checks (Required)
    • Add A-congestion-test-checks to run start-integration-test-checks (Optional)

Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

@anaye1997 anaye1997 added A-automation Area: Issues and PRs related to Automation L-added Log: Issues and PRs related to addition labels Aug 2, 2023
@anaye1997 anaye1997 changed the title 🚀 update check_tests pipeline to use org runtime runner 🚀 arc runner migration patch 2.1 Aug 2, 2023
ghzlatarev
ghzlatarev previously approved these changes Aug 3, 2023
@github-actions
Copy link

github-actions bot commented Aug 7, 2023

⚠️ Congestion test: 1-day congestion cost (calamari-runtime) is NOT above the target daily congestion cost

@github-actions
Copy link

github-actions bot commented Aug 7, 2023

⚠️ Congestion test: 1-day congestion cost (manta-runtime) is NOT above the target daily congestion cost

.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/workflows/check_tests.yml Show resolved Hide resolved
.github/workflows/check_tests.yml Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Please signoff on all commits with your name, email and gpg key for the Developer's Certificate of Origin.
git config --global user.name your_name
git config --global user.email you_email
COMMAND : git commit -s -S -m your_commit_message
-s = Signed-off-by
-S = Verify commit using gpg key
If there is more than one commit in your pull request and your git client is modern enough (2.13+), rebase the required number of commits with --signoff:
git rebase --signoff -S HEAD~<number_of_commits>
Then, force push:
git push -f origin <your_branch>
For instructions on managing gpg signature verification please visit: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

@anaye1997 anaye1997 force-pushed the feature/arc-runner-patch-2.1 branch 3 times, most recently from 1eab36a to 25fd606 Compare August 8, 2023 06:37
@anaye1997 anaye1997 force-pushed the feature/arc-runner-patch-2.1 branch from 374269d to aa19e17 Compare August 8, 2023 09:58
@anaye1997 anaye1997 force-pushed the feature/arc-runner-patch-2.1 branch from 0c9dc9e to 36184c4 Compare August 8, 2023 11:23
@ferrell-code ferrell-code added A-manta Area: Issues and PRs related to the Manta Runtime A-calamari Area: Issues and PRs related to the Calamari Runtime labels Aug 9, 2023
ghzlatarev
ghzlatarev previously approved these changes Aug 21, 2023
Signed-off-by: Anathan (Ana) Ye <[email protected]>
@anaye1997 anaye1997 removed the A-calamari Area: Issues and PRs related to the Calamari Runtime label Aug 21, 2023
Signed-off-by: Anathan (Ana) Ye <[email protected]>
Signed-off-by: Anathan (Ana) Ye <[email protected]>
Signed-off-by: Anathan (Ana) Ye <[email protected]>
Signed-off-by: Anathan (Ana) Ye <[email protected]>
Signed-off-by: Anathan (Ana) Ye <[email protected]>
Signed-off-by: Anathan (Ana) Ye <[email protected]>
@anaye1997 anaye1997 added the A-calamari Area: Issues and PRs related to the Calamari Runtime label Aug 21, 2023
anaye1997 and others added 9 commits August 21, 2023 23:17
Signed-off-by: Anathan (Ana) Ye <[email protected]>
Signed-off-by: Anathan (Ana) Ye <[email protected]>
Signed-off-by: Anathan (Ana) Ye <[email protected]>
Signed-off-by: Anathan (Ana) Ye <[email protected]>
Signed-off-by: Anathan (Ana) Ye <[email protected]>
Signed-off-by: Dengjianping <[email protected]>
Signed-off-by: Dengjianping <[email protected]>
Signed-off-by: Dengjianping <[email protected]>
@ghzlatarev ghzlatarev merged commit af50afb into manta Aug 22, 2023
19 checks passed
@ghzlatarev ghzlatarev deleted the feature/arc-runner-patch-2.1 branch August 22, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-automation Area: Issues and PRs related to Automation A-benchmark-checks A-calamari Area: Issues and PRs related to the Calamari Runtime A-congestion-test-checks A-integration-test-checks A-manta Area: Issues and PRs related to the Manta Runtime A-unit-test-checks C-enhancement Category: An issue proposing an enhancement or a PR with one L-added Log: Issues and PRs related to addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants