Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reference hardware and lower CI machine specs #1235

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

ghzlatarev
Copy link
Contributor

@ghzlatarev ghzlatarev commented Jul 24, 2023

Description


Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

Signed-off-by: Georgi Zlatarev <[email protected]>
@ghzlatarev ghzlatarev added C-enhancement Category: An issue proposing an enhancement or a PR with one A-manta Area: Issues and PRs related to the Manta Runtime A-calamari Area: Issues and PRs related to the Calamari Runtime A-ci Area: Continuous Integration L-changed Log: Issues and PRs related to changes labels Jul 24, 2023
@ghzlatarev ghzlatarev self-assigned this Jul 24, 2023
@ghzlatarev ghzlatarev changed the title USe smaller isntances Update reference hardware and lower CI machine specs Jul 24, 2023
@github-actions
Copy link

github-actions bot commented Jul 24, 2023

✅ Congestion test: 1-day congestion cost (manta-runtime) is above the target daily congestion cost

@github-actions
Copy link

github-actions bot commented Jul 24, 2023

⚠️ Congestion test: 1-day congestion cost (calamari-runtime) is NOT above the target daily congestion cost

@ghzlatarev ghzlatarev marked this pull request as ready for review July 24, 2023 06:19
@ghzlatarev ghzlatarev assigned anaye1997 and unassigned anaye1997 Jul 24, 2023
Copy link
Contributor

@anaye1997 anaye1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghzlatarev ghzlatarev merged commit 1d5ecc1 into manta Jul 24, 2023
40 checks passed
@ghzlatarev ghzlatarev deleted the ghzlatarev/reference-hardware-change branch July 24, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-calamari Area: Issues and PRs related to the Calamari Runtime A-ci Area: Continuous Integration A-manta Area: Issues and PRs related to the Manta Runtime C-enhancement Category: An issue proposing an enhancement or a PR with one L-changed Log: Issues and PRs related to changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants