Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Permissionless Asset Registry Feature #1212

Merged
merged 32 commits into from
Jul 20, 2023
Merged

Conversation

ferrell-code
Copy link
Contributor

@ferrell-code ferrell-code commented Jul 13, 2023

Description

Can use native token to create an asset for use on manta pay

Makes AssetRegistryMetadata a concrete type rather than generic

Creates an additional counter NextPermissionlessAssetId so the AssetIds of permissionless asset are separate from governance ones.

closes #892


Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
@ferrell-code ferrell-code added A-manta Area: Issues and PRs related to the Manta Runtime A-calamari Area: Issues and PRs related to the Calamari Runtime C-experiment Category: Experimental feature or tool A-manta-pay Area: Issues and PRs related to the MantaPay Pallet L-added Log: Issues and PRs related to addition labels Jul 13, 2023
@ferrell-code ferrell-code marked this pull request as draft July 13, 2023 23:54
@github-actions
Copy link

github-actions bot commented Jul 14, 2023

✅ Congestion test: 1-day congestion cost (manta-runtime) is above the target daily congestion cost

@github-actions
Copy link

github-actions bot commented Jul 14, 2023

⚠️ Congestion test: 1-day congestion cost (calamari-runtime) is NOT above the target daily congestion cost

Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
Signed-off-by: Charles Ferrell <[email protected]>
@ferrell-code ferrell-code marked this pull request as ready for review July 15, 2023 02:34
pallets/asset-manager/src/lib.rs Show resolved Hide resolved
pallets/asset-manager/src/tests.rs Outdated Show resolved Hide resolved
ghzlatarev
ghzlatarev previously approved these changes Jul 19, 2023
Signed-off-by: Charles Ferrell <[email protected]>
@Dengjianping
Copy link
Contributor

Because new extrinsic has been added to this pallet, so you have to add it to tx fee diff test.

thread 'diff_tx_fees::diff_tx_fees' panicked at 'assertion failed: `(left == right)`
  left: `9`,
 right: `8`: Please update new extrinsic here.', runtime/calamari/src/diff_tx_fees.rs:1178:9

@ferrell-code
Copy link
Contributor Author

ferrell-code commented Jul 20, 2023

Because new extrinsic has been added to this pallet, so you have to add it to tx fee diff test.

thread 'diff_tx_fees::diff_tx_fees' panicked at 'assertion failed: `(left == right)`
  left: `9`,
 right: `8`: Please update new extrinsic here.', runtime/calamari/src/diff_tx_fees.rs:1178:9

Done, also changed the README for the tx fee diff test if you want to take a look at that

ghzlatarev
ghzlatarev previously approved these changes Jul 20, 2023
@ghzlatarev ghzlatarev merged commit c4256a0 into manta Jul 20, 2023
@ghzlatarev ghzlatarev deleted the fer-permissionless-asset branch July 20, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-calamari Area: Issues and PRs related to the Calamari Runtime A-manta Area: Issues and PRs related to the Manta Runtime A-manta-pay Area: Issues and PRs related to the MantaPay Pallet C-experiment Category: Experimental feature or tool L-added Log: Issues and PRs related to addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make pallet-assets permissionless
3 participants