Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

48 more linting #50

Merged
merged 6 commits into from
Jun 12, 2024
Merged

48 more linting #50

merged 6 commits into from
Jun 12, 2024

Conversation

mschwoer
Copy link

fix more linting issues

Copy link
Collaborator

@jalew188 jalew188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from 48-basic-linting to development June 8, 2024 13:33
@mschwoer
Copy link
Author

@jalew188 added the mutable args again, only here I kept it the function calling is definitely an antiipattern :-)
https://github.com/MannLabs/alpharaw/pull/50/files#diff-1692d1647458c70954790b3583f225cfedc625320054e6caee41a718124df199L49-R71

@jalew188
Copy link
Collaborator

@jalew188 added the mutable args again, only here I kept it the function calling is definitely an antiipattern :-) https://github.com/MannLabs/alpharaw/pull/50/files#diff-1692d1647458c70954790b3583f225cfedc625320054e6caee41a718124df199L49-R71

Ha, python is too flexible.

@jalew188
Copy link
Collaborator

Ready to merge!

@jalew188 jalew188 merged commit 0cd21c4 into development Jun 12, 2024
2 checks passed
@jalew188 jalew188 deleted the 48-more-linting branch June 12, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants