Fix fasta in cli #448
Fix fasta in cli #448
Conversation
| # TODO add tests for _get_raw_path_list_from_args_and_config | ||
|
|
||
|
|
||
| def test_get_config_from_args(): |
There was a problem hiding this comment.
why don't we get the error, that we can only update existing keys?
There was a problem hiding this comment.
because this is another dictionary update method 🙈
I'll add a TODO
| {}, | ||
| { | ||
| # TODO raw_paths missing here | ||
| "library_path": mock_args.library, |
There was a problem hiding this comment.
Maybe I don't understand the mocking yet. why can we check for moch_args.library altough we never initialized it?
There was a problem hiding this comment.
yes, by default a mock will return another mock for any attribute, method, ... you try to access.
This test does not care what is passed, it just checks that the data is propagated as expected.
There was a problem hiding this comment.
maybe this sheds some light on mocking https://www.ines-panker.com/2020/06/01/python-mock.html
| config=None, | ||
| version=None, | ||
| output="/output", | ||
| fasta=None, |
There was a problem hiding this comment.
Same as before. we initialize it but now we don't check for it anymore?
There was a problem hiding this comment.
we initialize it as None otherwise it will return a mock (cf. above)
| # TODO add tests for _get_raw_path_list_from_args_and_config | ||
|
|
||
|
|
||
| def test_get_config_from_args(): |
#prfromhell