Implement split_maybe_lib_args() to handle paths with spaces #84
Conversation
When using `link_deps()` full paths are added to target_rustcflags, which doesn't work well with split_maybe_args(), as it splits on space. Fixes #81
|
@cuviper Could you try this out on Windows? I only ran it on Linux... |
| // split_maybe_args(), empty strings filtered out. | ||
| fn split_maybe_lib_args(&self, argstr: &Option<String>) -> Vec<String> { | ||
| if let Some(ref s) = *argstr { | ||
| s.split("-L") |
There was a problem hiding this comment.
What if I have a path like "-L Ooh-La-La"? Or even if you incorporating spaces in your split, " -L " is also legal in a path.
This will also act weird if people have their own non--L stuff in target_rustcflags.
|
Yeah, you're right. To solve this properly, |
|
IMO it's going to be too hard to really split args properly. Maybe you can get it good enough though... The best solution is really to maintain a vector of args from the start, but I see all the |
|
Yes, that would be new minor version, at least. Proper paths handling is hard :-/ Thanks for the feedback! |
|
BTW AppVeyor is free, and pretty easy to set up. That's how I noticed that the proposed rayon change didn't work on Windows. But I do have access to a Windows machine too, and this change is enough to get your |
|
I'll close this. I'll try to see if I can get a proper fix into rustc/compiletest, modelling |
When using
link_deps()full paths are added to target_rustcflags,which doesn't work well with split_maybe_args(), as it splits on space.
Fixes #81