Complete typing for logger_utils.py #4134
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VascoSch92
reviewed
Jan 26, 2025
| @@ -126,7 +126,7 @@ def parse_theme(parser: configparser.SectionProxy) -> Theme: | |||
| :func:`make_logger`. | |||
|
|
|||
| """ | |||
| theme = {key.replace("_", "."): parser[key] for key in parser} | |||
| theme: dict[str, Any] = {key.replace("_", "."): parser[key] for key in parser} | |||
There was a problem hiding this comment.
I might be wrong here, but I thought there is no difference between typing.Dict and dict anymore, since PEP 585 introduced generic type support for these built-in types.
There was a problem hiding this comment.
You are right. I was just thinking that you wanted to use typing everywhere ;-)
|
Hi! Could you please set |
|
I have continued work on this pull request, the updated pull request is available here: #4230 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Explanation: Why and how do your changes improve the library?
More work on #3375
Reviewer Checklist