Experimental: fix 11 tests #3979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chopan050
changed the title
Animation run time inside new run_time property setter| manager = Manager(Scene) | ||
| test_scene = manager.scene | ||
| test_scene.wait(1e-9, frozen_frame=frozen_frame) |
There was a problem hiding this comment.
We should probably get frozen_frame working instead of removing it from the test?
There was a problem hiding this comment.
frozen_frame was no longer among the parameters of the new Scene.wait(), so I assumed that it would no longer be needed.
I can put it there again, if it's necessary.
There was a problem hiding this comment.
Yeah, that might be my fault actually - I think I might have wanted to replace it with wait_until?
I guess for now until wait_until works this is fine.
| @@ -5,22 +5,22 @@ | |||
|
|
|||
| def test_ghost_vectors_len_and_types(): | |||
| manager = Manager(LinearTransformationScene) | |||
| scene = manager.scene | |||
| scene: LinearTransformationScene = manager.scene | |||
There was a problem hiding this comment.
It's interesting that we need this annotation - I thought it should be able to infer this already?
There was a problem hiding this comment.
Yeah. Honestly, I don't know why this happens.
JasonGrace2282
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
run_timevalidation forAnimationandScene.wait()#3982 into this branch in order to pass most tests intests/module/animations/test_animations.py.Motivation and Explanation: Why and how do your changes improve the library?
Links to added or changed documentation pages
Further Information and Comments
Reviewer Checklist