Add scale_stroke boolean parameter to VMobject.scale() to allow scaling stroke_width along with the VMobject
#3965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hey thanks for the PR!
It seems to me that a concept of a stroke/stroke outline is only applicable to VMobjects (Vectorized Mobjects), and doesn't make much sense in the case of an ImageMobject for example. Can you elaborate a bit more on why you choose to override the method in Mobject instead?
Also, it might be helpful to add a graphical unit test for this - see https://docs.manim.community/en/latest/contributing/testing.html#graphical-unit-test
…524-scale-stroke
for more information, see https://pre-commit.ci
JasonGrace2282
approved these changes
Oct 24, 2024
Co-authored-by: Aarush Deshpande <[email protected]>
Co-authored-by: Aarush Deshpande <[email protected]>
chopan050
approved these changes
Oct 28, 2024
chopan050
changed the title
scale_stroke boolean parameter to VMobject.scale() to allow scaling stroke_width along with the VMobject
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
This change adds an optional boolean to
Mobject.scale(...), which enables outline scaling:circle.scale(0.25, scale_stroke=True)Leading to the following changes:
(scale_stroke=False)
(scale_stroke=True)
This supports any object that has the
set_stroke(...)method.Negative scaling does not break the stroke, however, due to the way animation is interpolated, the outline width is inconsistent in the process of negative scaling.
Motivation and Explanation: Why and how do your changes improve the library?
This closes #3525, adding the ability to scale an object outline.
This is a university-driven PR
(Same as my PR for 3863) Just for context, this PR (same as some other recent ones on this repo) is motivated by a university assignment that requires us to contribute to an Open-Source project. PR merge is not required, however. I figured this information might affect your judgment.
Reviewer Checklist