-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: dvipsnames and svgnames color palettes #3913
base: main
Are you sure you want to change the base?
Feat: dvipsnames and svgnames color palettes #3913
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me! Some other stuff:
Do you mind updating this part of the docs?
https://manimce--3913.org.readthedocs.build/en/3913/reference/manim.utils.color.html
"""DVIPSNAMES Colors | ||
|
||
This module contains colors defined in the DVIPS driver and are commonly accessed | ||
as named colors in LaTeX via the `\\usepackage[dvipsnames]{xcolor}` package. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Single backticks are italics in sphinx, I think inline code looks nicer ;)
as named colors in LaTeX via the `\\usepackage[dvipsnames]{xcolor}` package. | |
as named colors in LaTeX via the ``\\usepackage[dvipsnames]{xcolor}`` package. |
You also might want to use a raw docstring - add an r
to the beginning of """
, and then you can get rid of the double \\
"""SVGNAMES Colors | ||
|
||
This module contains colors defined in the SVG 1.1 specification and are commonly | ||
accessed as named colors in LaTeX via the `\\usepackage[svgnames]{xcolor}` package. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above
accessed as named colors in LaTeX via the `\\usepackage[svgnames]{xcolor}` package. | |
accessed as named colors in LaTeX via the ``\\usepackage[svgnames]{xcolor}`` package. |
Overview: What does this pull request change?
DVIPSNAMES
andSVGNAMES
for colors commonly used in LaTeX via thexcolor
package.Motivation and Explanation: Why and how do your changes improve the library?
Links to added or changed documentation pages
Further Information and Comments
Reviewer Checklist