Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed typehint in types.rst and replaced outdated reference to manim.typing.Image with manim.typing.PixelArray #3878

Merged
merged 2 commits into from
Oct 20, 2024
Merged

Fixed typehint in types.rst and replaced outdated reference to manim.typing.Image with manim.typing.PixelArray #3878

merged 2 commits into from
Oct 20, 2024

Conversation

JasonGrace2282
Copy link
Member

  • Fix incorrect typehint in return value
  • Change manim.typing.Image → manim.typing.PixelArray
  • Clarified the difference between PixelArray and PIL.Image.Image

@JasonGrace2282
fix some mistakes in types.rst
b2205aa 
and add clarifications
@JasonGrace2282 JasonGrace2282 added the documentation Improvements or additions to documentation label Jul 21, 2024
@JasonGrace2282 JasonGrace2282 self-assigned this Jul 21, 2024
chopan050
chopan050 approved these changes Oct 20, 2024
View reviewed changes
Copy link
Contributor

@chopan050 chopan050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chopan050 chopan050 added the pr:easy review There is nothing particular (i.e, it's about a general/small thing) to know for review! label Oct 20, 2024
@chopan050 chopan050 changed the title fix some mistakes in types.rst Fix a typehint in types.rst and replace outdated reference to manim.typing.Image with manim.typing.PixelArray Oct 20, 2024
@chopan050 chopan050 changed the title Fix a typehint in types.rst and replace outdated reference to manim.typing.Image with manim.typing.PixelArray Fixed typehint in types.rst and replaced outdated reference to manim.typing.Image with manim.typing.PixelArray Oct 20, 2024
@chopan050 chopan050 enabled auto-merge (squash) October 20, 2024 00:31
@chopan050 chopan050 merged commit fc58a46 into ManimCommunity:main Oct 20, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chopan050 chopan050 chopan050 approved these changes

Assignees

@JasonGrace2282 JasonGrace2282

Labels
documentation Improvements or additions to documentation pr:easy review There is nothing particular (i.e, it's about a general/small thing) to know for review!
Projects
Dev Board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JasonGrace2282 @chopan050