Rails 6.0 #90
Merged
Rails 6.0 #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 4, 2020
bdunne
reviewed
Dec 8, 2020
| @@ -15,7 +15,7 @@ Gem::Specification.new do |spec| | |||
| spec.required_ruby_version = "> 2.4" | |||
| spec.files = Dir["{app,config,lib}/**/*"] | |||
|
|
|||
| spec.add_dependency "activesupport", "~> 5.2.4", ">= 5.2.4.3" | |||
There was a problem hiding this comment.
Can we apply https://github.com/ManageIQ/activerecord-id_regions/pull/18/files#r537735807 here as well?
Allow the next release to support Rails 6.0 applications as well.
|
Checked commit NickLaMuro@e67100b with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint |
Fryguy
approved these changes
Dec 10, 2020
bdunne
approved these changes
Dec 10, 2020
|
Is this ready to un-wip? |
|
@bdunne I have some failures in the cross-repo tests that I want to resolve before I commit to this. |
bdunne
approved these changes
Dec 14, 2020
|
@agrare Can you push a new release to rubygems.org? I'm not an owner on this one. |
|
Released v2.0.3 with this change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links