Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Fix warnings raised by URI 1.0.1 #141

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[WIP] Fix warnings raised by URI 1.0.1 #141

wants to merge 2 commits into from

Conversation

jrafanie
Copy link
Member

@jrafanie jrafanie commented Nov 8, 2024 •
edited
Loading

@jrafanie jrafanie force-pushed the fix-uri-1-0-1-warnings branch from 17fcced to d9b4b02 Compare November 8, 2024 17:58
agrare
agrare previously approved these changes Nov 8, 2024
View reviewed changes
@agrare agrare dismissed their stale review November 8, 2024 18:03

D'oh just saw the tests are failing

@jrafanie jrafanie force-pushed the fix-uri-1-0-1-warnings branch from d9b4b02 to 2da6fd7 Compare November 8, 2024 18:07
@jrafanie jrafanie changed the title Fix warnings raised by URI 1.0.1 [WIP] Fix warnings raised by URI 1.0.1 Nov 8, 2024
@jrafanie jrafanie mentioned this pull request Nov 8, 2024
Open
9 tasks
@jrafanie jrafanie force-pushed the fix-uri-1-0-1-warnings branch from 2da6fd7 to c649999 Compare November 8, 2024 21:29
@jrafanie jrafanie added the wip label Nov 11, 2024
@jrafanie jrafanie closed this Dec 10, 2024
@jrafanie jrafanie reopened this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrare agrare agrare left review comments

@Fryguy Fryguy Awaiting requested review from Fryguy Fryguy is a code owner

Assignees
No one assigned
Labels
cleanup wip
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrafanie @agrare