Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up remaining #to_miq_a callers that are covered by tests #20379

Merged
merged 2 commits into from
Jul 24, 2020
Merged

Clean up remaining #to_miq_a callers that are covered by tests #20379

merged 2 commits into from
Jul 24, 2020

Conversation

bdunne
Copy link
Member

@bdunne bdunne commented Jul 22, 2020 •
edited
Loading

@bdunne bdunne force-pushed the tested_to_miq_a branch from 0c0024e to 0a69288 Compare July 22, 2020 15:20
@bdunne bdunne mentioned this pull request Jul 22, 2020
Merged
4 tasks
jrafanie
jrafanie reviewed Jul 24, 2020
View reviewed changes
lib/miq_expression.rb Outdated Show resolved Hide resolved
@miq-bot
Copy link
Member

miq-bot commented Jul 24, 2020

Checked commits bdunne/manageiq@0a69288~...a29e758 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
6 files checked, 0 offenses detected
Everything looks fine. 🍪

@jrafanie jrafanie merged commit cd88556 into ManageIQ:master Jul 24, 2020
@bdunne bdunne deleted the tested_to_miq_a branch July 24, 2020 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrare agrare agrare approved these changes

@jrafanie jrafanie jrafanie approved these changes

@Fryguy Fryguy Awaiting requested review from Fryguy Fryguy is a code owner

@gtanzillo gtanzillo Awaiting requested review from gtanzillo

@kbrock kbrock Awaiting requested review from kbrock kbrock is a code owner

Assignees

@jrafanie jrafanie

Labels
technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bdunne @miq-bot @jrafanie @agrare