Rails 7.1 / Rails 7.0 compatible changes #9336
Merged
+9
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rails 7.0 was reporting this warning: DEPRECATION WARNING: Range#to_s(:dash) is deprecated. Please use Range#to_fs(:dash) instead. (called from port_range_helper at /home/runner/work/manageiq-ui-classic/manageiq-ui-classic/app/helpers/security_group_helper/textual_summary.rb:105)
In rails 7.1, the response.body in the redirect is an empty string.
53 tasks
jrafanie
commented
Feb 5, 2025
| expect(response.body).to include("redirected") | ||
| expect(response.body).to include("ems_infra") | ||
| expect(response.status).to eq(302) | ||
| assert_redirected_to(%r(#{controller.ems_infra_path(@ems.id)})) |
There was a problem hiding this comment.
I use a regex here as I didn't think it was necessary to test the whole URL, such as:
http://test.host/ems_infra/1040?display=hosts&flash_msg=Nodes+were+added+successfully.+Refresh+queued.
|
@GilbertCherrie FYI, this fixes some issues on rails 7.1 in a 7.0 backward compatible way. Keep it in mind as we move to rails 7.1 soon. |
Fryguy
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix rails 7.1 removal, use to_fs(:dash) instead of Range#to_s(:dash)
Rails 7.0 was reporting this warning:
DEPRECATION WARNING: Range#to_s(:dash) is deprecated. Please use Range#to_fs(:dash) instead. (called from port_range_helper at /home/runner/work/manageiq-ui-classic/manageiq-ui-classic/app/helpers/security_group_helper/textual_summary.rb:105)
Assert redirect in a rails 7.1 friendly way
In rails 7.1, the response.body in the redirect is an empty string.