-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrating react-markdown with miq-structured-list and adding a markdown preview to service-catalog-item's long-description field #8972
Conversation
43f7043
to
32be958
Compare
4007c6a
to
0edc631
Compare
This seems to be working, but when we try to edit, the code mirror is not loading up. Screen.Recording.2023-11-27.at.7.10.13.PM.mov |
8749ad0
to
5fa4a8b
Compare
@jeffibm Ignore the bot on this one - I thought I had it disabled. |
5d496d4
to
8106421
Compare
dde680a
to
c73372b
Compare
c73372b
to
457607c
Compare
Checked commit jeffbonson@457607c with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint app/views/catalog/_form_details_info.html.haml
|
Nice work @jeffibm it looks nice! My only concern is how the side by side looks on small screens but we can certainly take that on if it's a problem. |
Technically they will all be in quinteros because I will be merging master into quinteros next week. |
ToDo's
react-markdown
packagereact-markdown
component withMiqStructuredList
codeMirror
component on pageLoad- Code mirror works only on the first tab.
- Contents were not showing up in the second tab.
- Fixed it by implementing redux in MiqCustomTab component and updated the snapshots.
code-mirror
component for editing thereact-markdown
component for live previewcode-mirror
should enable the save button in ruby form.Before
After