Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the package babel/core #8959

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

amalvijayan03
Copy link
Contributor

@amalvijayan03 amalvijayan03 commented Nov 8, 2023

Fix for the issue : GHSA-67hx-6x53-jw92
A security vulnerability was reported with the babel/traverse package, which we aren't using directly. As a workaround, we've updated the babel/core package, which will now include the latest version of babel/traverse.

@amalvijayan03 amalvijayan03 requested a review from a team as a code owner November 8, 2023 05:10
@amalvijayan03 amalvijayan03 changed the title Updated the package babel/core [WIP]Updated the package babel/core Nov 8, 2023
@miq-bot
Copy link
Member

miq-bot commented Nov 8, 2023

Checked commit amalvijayan03@3b14668 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@jeffibm
Copy link
Member

jeffibm commented Nov 8, 2023

Hey @amalvijayan03 , the snapshots appeared and git hub actions seems to have passed all checks now.

Can you do a random testing with the browser console opened? Check for any issues with forms that have drop-down boxes.

@jeffibm jeffibm self-assigned this Nov 8, 2023
@jeffibm
Copy link
Member

jeffibm commented Nov 9, 2023

Hey @amalvijayan03 , once the testing is done, please remove the WIP from the PR title.

@amalvijayan03
Copy link
Contributor Author

Tested the changes in local has not affected the overall functionality

@amalvijayan03 amalvijayan03 changed the title [WIP]Updated the package babel/core Updated the package babel/core Nov 9, 2023
@miq-bot miq-bot removed the wip label Nov 9, 2023
Copy link
Member

@jrafanie jrafanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we describe why we're updating these packages? Also, is it safe to backport to quinteros?

EDIT: When we look at this in the future, it would be good to know what issue this solves.

@jeffibm
Copy link
Member

jeffibm commented Nov 14, 2023

Can we describe why we're updating these packages? Also, is it safe to backport to quinteros?

EDIT: When we look at this in the future, it would be good to know what issue this solves.

@amalvijayan03 , could you please update the description.

@amalvijayan03
Copy link
Contributor Author

Can we describe why we're updating these packages? Also, is it safe to backport to quinteros?

EDIT: When we look at this in the future, it would be good to know what issue this solves.

I have updated the issue details in the description. Certainly, we can backport to Quinteros.
If this suffices, may we proceed with the merge?

Copy link
Member

@jrafanie jrafanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@jrafanie jrafanie merged commit 7cb97e8 into ManageIQ:master Nov 14, 2023
8 checks passed
@jrafanie jrafanie assigned jrafanie and unassigned jeffibm Nov 14, 2023
@jrafanie
Copy link
Member

@jeffibm is this for backport? Please set backport if so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants