-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated the package babel/core #8959
Conversation
Checked commit amalvijayan03@3b14668 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint |
Hey @amalvijayan03 , the snapshots appeared and git hub actions seems to have passed all checks now. Can you do a random testing with the browser console opened? Check for any issues with forms that have drop-down boxes. |
Hey @amalvijayan03 , once the testing is done, please remove the WIP from the PR title. |
Tested the changes in local has not affected the overall functionality |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we describe why we're updating these packages? Also, is it safe to backport to quinteros?
EDIT: When we look at this in the future, it would be good to know what issue this solves.
@amalvijayan03 , could you please update the description. |
I have updated the issue details in the description. Certainly, we can backport to Quinteros. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM
@jeffibm is this for backport? Please set backport if so. |
Fix for the issue : GHSA-67hx-6x53-jw92
A security vulnerability was reported with the babel/traverse package, which we aren't using directly. As a workaround, we've updated the babel/core package, which will now include the latest version of babel/traverse.