Mark workflow controllers as prototype #8848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit Fryguy@27d2e9b with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint |
jeffibm
approved these changes
Jul 5, 2023
|
We can merge this now and you can also include it in #8834 |
|
Backported to |
Fryguy
pushed a commit
that referenced
this pull request
Jul 25, 2023
Mark workflow controllers as prototype (cherry picked from commit 0f5847a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR wrap prototype checks around the workflows and workflow_repositories controllers. Note that setting the prototype flag still requires restarting the worker - I haven't found a way to do that yet because it requires reloading the menu and we don't seem to have a hook for that just yet, so I wanted to just get this base functionality in first.
Part of #8715
@DavidResende0 Please review.