Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer Array.wrap over #to_miq_a #7213

Merged
merged 1 commit into from
Jul 20, 2020
Merged

Prefer Array.wrap over #to_miq_a #7213

merged 1 commit into from
Jul 20, 2020

Conversation

bdunne
Copy link
Member

@bdunne bdunne commented Jul 16, 2020

@miq-bot
Copy link
Member

miq-bot commented Jul 16, 2020

Checked commit bdunne@20210c1 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
5 files checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:
warning: parser/current is loading parser/ruby25, which recognizes
warning: 2.5.8-compliant syntax, but you are running 2.5.7.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

jrafanie
jrafanie approved these changes Jul 17, 2020
View reviewed changes
Copy link
Member

@jrafanie jrafanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mzazrivec mzazrivec merged commit 059ed12 into ManageIQ:master Jul 20, 2020
@bdunne bdunne deleted the to_miq_a branch July 22, 2020 13:58
@bdunne bdunne mentioned this pull request Jul 22, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzazrivec mzazrivec mzazrivec approved these changes

@jrafanie jrafanie jrafanie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bdunne @miq-bot @jrafanie @mzazrivec