Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a version limit on activesupport gem #210

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Add a version limit on activesupport gem #210

merged 1 commit into from
Dec 10, 2024

Conversation

agrare
Copy link
Member

@agrare agrare commented Dec 10, 2024 •
edited
Loading

Without an upper limit on activesupport this was bringing in v8.0.0 which was conflicting with core's uri version.

jrafanie
jrafanie approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@jrafanie jrafanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for now until we move to the newer URI. I'm hesitant to add another dependency we need to loosen later on but I see no other solutions for now. It should be tested in a similar set of common dependencies as core. It's not really a standalone gem.

@jrafanie jrafanie merged commit 6e09085 into ManageIQ:master Dec 10, 2024
3 of 4 checks passed
@agrare agrare deleted the add_upper_limit_on_activesupport branch December 10, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrafanie jrafanie jrafanie approved these changes

Assignees

@jrafanie jrafanie

Labels
dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agrare @jrafanie