Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Kernel.taint #199

Merged
merged 4 commits into from
Sep 24, 2024
Merged

Remove Kernel.taint #199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5103411
Remove Kernel.taint
kbrock Sep 19, 2024
c96ff06
File.exists renamed to File.exist
kbrock Sep 20, 2024
40db8fc
ruby 3.2 dropped Fixnum
kbrock Sep 20, 2024
dde4257
test with ruby 3.3
kbrock Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ jobs:
ruby-version:
- '3.0'
Fryguy marked this conversation as resolved.
Show resolved Hide resolved
- '3.1'
Fryguy marked this conversation as resolved.
Show resolved Hide resolved
- '3.2'
- '3.3'
env:
CC_TEST_REPORTER_ID: "${{ secrets.CC_TEST_REPORTER_ID }}"
steps:
Expand Down
4 changes: 2 additions & 2 deletions lib/metadata/util/find_class_methods.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,12 +56,12 @@ def self.find(path, max_depth = nil)

while (file = paths.shift)
depth = depths.shift
yield file.dup.taint
yield file.dup
next if max_depth && depth + 1 > max_depth

get_dir_entries(file).each do |f|
f = File.join(file, f)
paths.unshift f.untaint
paths.unshift f
depths.unshift depth + 1
end
end
Expand Down
2 changes: 1 addition & 1 deletion spec/support/camcorder_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def self.deintercept_all

class Recorder
def start
if File.exists?(filename)
if File.exist?(filename)
contents = File.read(filename)
@recordings = YAML.respond_to?(:safe_load) ? YAML.safe_load(contents, :permitted_classes => [Camcorder::Recording, Symbol]) : YAML.load(contents)
@replaying = true
Expand Down
2 changes: 1 addition & 1 deletion test/extract/tc_registry.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ def validateVmXml(xml, category)
refute_nil(xml.root.attributes['created_on'])
refute_nil(xml.root.attributes['display_time'])
assert_instance_of(String, xml.root.attributes['display_time'])
assert_instance_of(Fixnum, eval(xml.root.attributes['created_on']))
assert_instance_of(Integer, eval(xml.root.attributes['created_on']))

# Use the as an exit point to generate the reference xml for testing
# createReferenceXml(xml, category)
Expand Down